Commit 769f01ef authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

hamradio: 6pack: fix error return code

Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4fc3ecde
...@@ -662,7 +662,8 @@ static int sixpack_open(struct tty_struct *tty) ...@@ -662,7 +662,8 @@ static int sixpack_open(struct tty_struct *tty)
tty->receive_room = 65536; tty->receive_room = 65536;
/* Now we're ready to register. */ /* Now we're ready to register. */
if (register_netdev(dev)) err = register_netdev(dev);
if (err)
goto out_free; goto out_free;
tnc_init(sp); tnc_init(sp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment