Commit 76bf3441 authored by Ben Dooks's avatar Ben Dooks Committed by Tejun Heo

ata: sata_mv: fix mis-conversion in mv_write_cached_reg()

Fix the signed issue in mv_write_cached_reg() where the laddr
is assigned from a (long)addr instead of (unsigned long)addr.

Fixes the following warnings:

drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression
drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression
drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression
drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression
Signed-off-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent f52a4c74
...@@ -986,7 +986,7 @@ static inline void mv_write_cached_reg(void __iomem *addr, u32 *old, u32 new) ...@@ -986,7 +986,7 @@ static inline void mv_write_cached_reg(void __iomem *addr, u32 *old, u32 new)
* Looks like a lot of fuss, but it avoids an unnecessary * Looks like a lot of fuss, but it avoids an unnecessary
* +1 usec read-after-write delay for unaffected registers. * +1 usec read-after-write delay for unaffected registers.
*/ */
laddr = (long)addr & 0xffff; laddr = (unsigned long)addr & 0xffff;
if (laddr >= 0x300 && laddr <= 0x33c) { if (laddr >= 0x300 && laddr <= 0x33c) {
laddr &= 0x000f; laddr &= 0x000f;
if (laddr == 0x4 || laddr == 0xc) { if (laddr == 0x4 || laddr == 0xc) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment