Commit 77618db3 authored by Nick Terrell's avatar Nick Terrell Committed by Nick Terrell

zstd: Fix array-index-out-of-bounds UBSAN warning

Zstd used an array of length 1 to mean a flexible array for C89
compatibility. Switch to a C99 flexible array to fix the UBSAN warning.

Tested locally by booting the kernel and writing to and reading from a
BtrFS filesystem with zstd compression enabled. I was unable to reproduce
the issue before the fix, however it is a trivial change.

Link: https://lkml.kernel.org/r/20231012213428.1390905-1-nickrterrell@gmail.com
Reported-by: syzbot+1f2eb3e8cd123ffce499@syzkaller.appspotmail.com
Reported-by: default avatarEric Biggers <ebiggers@kernel.org>
Reported-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarNick Terrell <terrelln@fb.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
parent ffc25326
......@@ -312,7 +312,7 @@ size_t FSE_decompress_wksp(void* dst, size_t dstCapacity, const void* cSrc, size
typedef struct {
short ncount[FSE_MAX_SYMBOL_VALUE + 1];
FSE_DTable dtable[1]; /* Dynamically sized */
FSE_DTable dtable[]; /* Dynamically sized */
} FSE_DecompressWksp;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment