Commit 77b1ab61 authored by Ben Skeggs's avatar Ben Skeggs

drm/nouveau/flcn/msgq: switch to falcon queue printk macros

Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent e9602a1b
...@@ -56,7 +56,6 @@ msg_queue_pop(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue, ...@@ -56,7 +56,6 @@ msg_queue_pop(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue,
void *data, u32 size) void *data, u32 size)
{ {
struct nvkm_falcon *falcon = priv->falcon; struct nvkm_falcon *falcon = priv->falcon;
const struct nvkm_subdev *subdev = priv->falcon->owner;
u32 head, tail, available; u32 head, tail, available;
head = nvkm_falcon_rd32(falcon, queue->head_reg); head = nvkm_falcon_rd32(falcon, queue->head_reg);
...@@ -68,7 +67,8 @@ msg_queue_pop(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue, ...@@ -68,7 +67,8 @@ msg_queue_pop(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue,
available = head - tail; available = head - tail;
if (size > available) { if (size > available) {
nvkm_warn(subdev, "message data smaller than read request\n"); FLCNQ_ERR(queue, "requested %d bytes, but only %d available",
size, available);
return -EINVAL; return -EINVAL;
} }
...@@ -81,7 +81,6 @@ static int ...@@ -81,7 +81,6 @@ static int
msg_queue_read(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue, msg_queue_read(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue,
struct nv_falcon_msg *hdr) struct nv_falcon_msg *hdr)
{ {
const struct nvkm_subdev *subdev = priv->falcon->owner;
int ret = 0; int ret = 0;
msg_queue_open(priv, queue); msg_queue_open(priv, queue);
...@@ -91,12 +90,12 @@ msg_queue_read(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue, ...@@ -91,12 +90,12 @@ msg_queue_read(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue,
ret = msg_queue_pop(priv, queue, hdr, HDR_SIZE); ret = msg_queue_pop(priv, queue, hdr, HDR_SIZE);
if (ret) { if (ret) {
nvkm_error(subdev, "failed to read message header: %d\n", ret); FLCNQ_ERR(queue, "failed to read message header");
goto close; goto close;
} }
if (hdr->size > MSG_BUF_SIZE) { if (hdr->size > MSG_BUF_SIZE) {
nvkm_error(subdev, "message too big (%d bytes)\n", hdr->size); FLCNQ_ERR(queue, "message too big, %d bytes", hdr->size);
ret = -ENOSPC; ret = -ENOSPC;
goto close; goto close;
} }
...@@ -106,7 +105,7 @@ msg_queue_read(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue, ...@@ -106,7 +105,7 @@ msg_queue_read(struct nvkm_msgqueue *priv, struct nvkm_msgqueue_queue *queue,
ret = msg_queue_pop(priv, queue, (hdr + 1), read_size); ret = msg_queue_pop(priv, queue, (hdr + 1), read_size);
if (ret) { if (ret) {
nvkm_error(subdev, "failed to read message: %d\n", ret); FLCNQ_ERR(queue, "failed to read message data");
goto close; goto close;
} }
} }
...@@ -122,12 +121,11 @@ msgqueue_msg_handle(struct nvkm_msgqueue *priv, ...@@ -122,12 +121,11 @@ msgqueue_msg_handle(struct nvkm_msgqueue *priv,
struct nvkm_falcon_msgq *msgq, struct nvkm_falcon_msgq *msgq,
struct nv_falcon_msg *hdr) struct nv_falcon_msg *hdr)
{ {
const struct nvkm_subdev *subdev = priv->falcon->owner;
struct nvkm_falcon_qmgr_seq *seq; struct nvkm_falcon_qmgr_seq *seq;
seq = &msgq->qmgr->seq.id[hdr->seq_id]; seq = &msgq->qmgr->seq.id[hdr->seq_id];
if (seq->state != SEQ_STATE_USED && seq->state != SEQ_STATE_CANCELLED) { if (seq->state != SEQ_STATE_USED && seq->state != SEQ_STATE_CANCELLED) {
nvkm_error(subdev, "msg for unknown sequence %d", seq->id); FLCNQ_ERR(msgq, "message for unknown sequence %08x", seq->id);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment