Commit 7819d1c7 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda - Add missing hda_gen_spec to struct via_spec

The commit [4b527b65 ALSA: hda - limit internal mic boost for Asus
X202E] introduced the use of auto-parser code, but it forgot to add
struct hda_gen_spec at the head of codec->spec which the auto-parser
assumes silently.  Without this record, it may result in memory
corruption.

This patch adds the missing piece.

Cc: <stable@vger.kernel.org> [v3.5+]
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 8d032a8f
...@@ -118,6 +118,8 @@ enum { ...@@ -118,6 +118,8 @@ enum {
}; };
struct via_spec { struct via_spec {
struct hda_gen_spec gen;
/* codec parameterization */ /* codec parameterization */
const struct snd_kcontrol_new *mixers[6]; const struct snd_kcontrol_new *mixers[6];
unsigned int num_mixers; unsigned int num_mixers;
...@@ -246,6 +248,7 @@ static struct via_spec * via_new_spec(struct hda_codec *codec) ...@@ -246,6 +248,7 @@ static struct via_spec * via_new_spec(struct hda_codec *codec)
/* VT1708BCE & VT1708S are almost same */ /* VT1708BCE & VT1708S are almost same */
if (spec->codec_type == VT1708BCE) if (spec->codec_type == VT1708BCE)
spec->codec_type = VT1708S; spec->codec_type = VT1708S;
snd_hda_gen_init(&spec->gen);
return spec; return spec;
} }
...@@ -1627,6 +1630,7 @@ static void via_free(struct hda_codec *codec) ...@@ -1627,6 +1630,7 @@ static void via_free(struct hda_codec *codec)
vt1708_stop_hp_work(spec); vt1708_stop_hp_work(spec);
kfree(spec->bind_cap_vol); kfree(spec->bind_cap_vol);
kfree(spec->bind_cap_sw); kfree(spec->bind_cap_sw);
snd_hda_gen_free(&spec->gen);
kfree(spec); kfree(spec);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment