Commit 785f7422 authored by Ira Weiny's avatar Ira Weiny Committed by Doug Ledford

IB/qib: Fix qib_mr structure

struct qib_mr requires the mr member be the last because struct
qib_mregion contains a dynamic array at the end.  The additions
of members should have been placed before this structure as the
comment noted.

Failure to do so was causing random memory corruption.  Reproducing
this bug was easy to do by running the client and server of
ib_write_bw -s 8 -n 5 on the same node.

This BUG() was tripped in a slab debug kernel:

kernel BUG at mm/slab.c:2572!

Fixes: 38071a46 ("IB/qib: Support the new memory registration API")
Reviewed-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 527e9316
...@@ -329,9 +329,9 @@ struct qib_sge { ...@@ -329,9 +329,9 @@ struct qib_sge {
struct qib_mr { struct qib_mr {
struct ib_mr ibmr; struct ib_mr ibmr;
struct ib_umem *umem; struct ib_umem *umem;
struct qib_mregion mr; /* must be last */
u64 *pages; u64 *pages;
u32 npages; u32 npages;
struct qib_mregion mr; /* must be last */
}; };
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment