Commit 793cde3d authored by Marc Zyngier's avatar Marc Zyngier Committed by Luis Henriques

arm64: KVM: Fix TLB invalidation by IPA/VMID

commit 55e858b7 upstream.

It took about two years for someone to notice that the IPA passed
to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing
is not as good as it should be...

Paper bag time for me.
Reported-by: default avatarMario Smarduch <m.smarduch@samsung.com>
Tested-by: default avatarMario Smarduch <m.smarduch@samsung.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarShannon Zhao <shannon.zhao@linaro.org>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent b1ad37aa
...@@ -629,6 +629,7 @@ ENTRY(__kvm_tlb_flush_vmid_ipa) ...@@ -629,6 +629,7 @@ ENTRY(__kvm_tlb_flush_vmid_ipa)
* Instead, we invalidate Stage-2 for this IPA, and the * Instead, we invalidate Stage-2 for this IPA, and the
* whole of Stage-1. Weep... * whole of Stage-1. Weep...
*/ */
lsr x1, x1, #12
tlbi ipas2e1is, x1 tlbi ipas2e1is, x1
/* /*
* We have to ensure completion of the invalidation at Stage-2, * We have to ensure completion of the invalidation at Stage-2,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment