Commit 7993bc1f authored by Roland McGrath's avatar Roland McGrath Committed by Linus Torvalds

execve: improve interactivity with large arguments

This adds a preemption point during the copying of the argument and
environment strings for execve, in copy_strings().  There is already
a preemption point in the count() loop, so this doesn't add any new
points in the abstract sense.

When the total argument+environment strings are very large, the time
spent copying them can be much more than a normal user time slice.
So this change improves the interactivity of the rest of the system
when one process is doing an execve with very large arguments.
Signed-off-by: default avatarRoland McGrath <roland@redhat.com>
Reviewed-by: default avatarKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1b528181
...@@ -419,6 +419,8 @@ static int copy_strings(int argc, const char __user *const __user *argv, ...@@ -419,6 +419,8 @@ static int copy_strings(int argc, const char __user *const __user *argv,
while (len > 0) { while (len > 0) {
int offset, bytes_to_copy; int offset, bytes_to_copy;
cond_resched();
offset = pos % PAGE_SIZE; offset = pos % PAGE_SIZE;
if (offset == 0) if (offset == 0)
offset = PAGE_SIZE; offset = PAGE_SIZE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment