Commit 79bb7147 authored by Dave Jones's avatar Dave Jones Committed by Adrian Bunk

[ALSA] ad1848 double free

snd_ctl_add() already kfree's on error.

Coverity #956
Signed-off-by: default avatarDave Jones <davej@redhat.com>
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
parent 5bee6f62
...@@ -1202,10 +1202,8 @@ int snd_ad1848_add_ctl(struct snd_ad1848 *chip, const char *name, int index, int ...@@ -1202,10 +1202,8 @@ int snd_ad1848_add_ctl(struct snd_ad1848 *chip, const char *name, int index, int
strlcpy(ctl->id.name, name, sizeof(ctl->id.name)); strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
ctl->id.index = index; ctl->id.index = index;
ctl->private_value = value; ctl->private_value = value;
if ((err = snd_ctl_add(chip->card, ctl)) < 0) { if ((err = snd_ctl_add(chip->card, ctl)) < 0)
snd_ctl_free_one(ctl);
return err; return err;
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment