Commit 7a082a24 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Dmitry Torokhov

Input: appletouch - replace GFP_ATOMIC with GFP_KERNEL

atp_open(), atp_recover() and atp_resume() are never called in atomic
context. They call usb_submit_urb() with GFP_ATOMIC, which is not
necessary. GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 434ca100
...@@ -810,7 +810,7 @@ static int atp_open(struct input_dev *input) ...@@ -810,7 +810,7 @@ static int atp_open(struct input_dev *input)
{ {
struct atp *dev = input_get_drvdata(input); struct atp *dev = input_get_drvdata(input);
if (usb_submit_urb(dev->urb, GFP_ATOMIC)) if (usb_submit_urb(dev->urb, GFP_KERNEL))
return -EIO; return -EIO;
dev->open = true; dev->open = true;
...@@ -976,7 +976,7 @@ static int atp_recover(struct atp *dev) ...@@ -976,7 +976,7 @@ static int atp_recover(struct atp *dev)
if (error) if (error)
return error; return error;
if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC)) if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
return -EIO; return -EIO;
return 0; return 0;
...@@ -994,7 +994,7 @@ static int atp_resume(struct usb_interface *iface) ...@@ -994,7 +994,7 @@ static int atp_resume(struct usb_interface *iface)
{ {
struct atp *dev = usb_get_intfdata(iface); struct atp *dev = usb_get_intfdata(iface);
if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC)) if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
return -EIO; return -EIO;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment