Commit 7a228aaa authored by akpm@osdl.org's avatar akpm@osdl.org Committed by Linus Torvalds

[PATCH] arm: add comment about dma_supported()

)


From: Russell King <rmk+lkml@arm.linux.org.uk>

The ARM dma_supported() is rather basic, and I don't think it takes into
account everything that it should do (eg, whether the mask agrees with what
we'd return for GFP_DMA allocations).  Note this.
Signed-off-by: default avatarRussell King <rmk@arm.linux.org.uk>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 7aa52f51
...@@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr, size_t size, int rw); ...@@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr, size_t size, int rw);
* properly. For example, if your device can only drive the low 24-bits * properly. For example, if your device can only drive the low 24-bits
* during bus mastering, then you would pass 0x00ffffff as the mask * during bus mastering, then you would pass 0x00ffffff as the mask
* to this function. * to this function.
*
* FIXME: This should really be a platform specific issue - we should
* return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
*/ */
static inline int dma_supported(struct device *dev, u64 mask) static inline int dma_supported(struct device *dev, u64 mask)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment