Commit 7a55b570 authored by Shawn Lin's avatar Shawn Lin Committed by Bjorn Helgaas

dt-bindings: PCI: rockchip: Convert to per-lane PHY model

Deprecate legacy PHY model and encourage per-lane PHY model.
Signed-off-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarBrian Norris <briannorris@chromium.org>
Acked-by: default avatarRob Herring <robh@kernel.org>
parent e9a60cac
...@@ -19,8 +19,6 @@ Required properties: ...@@ -19,8 +19,6 @@ Required properties:
- "pm" - "pm"
- msi-map: Maps a Requester ID to an MSI controller and associated - msi-map: Maps a Requester ID to an MSI controller and associated
msi-specifier data. See ./pci-msi.txt msi-specifier data. See ./pci-msi.txt
- phys: From PHY bindings: Phandle for the Generic PHY for PCIe.
- phy-names: MUST be "pcie-phy".
- interrupts: Three interrupt entries must be specified. - interrupts: Three interrupt entries must be specified.
- interrupt-names: Must include the following names - interrupt-names: Must include the following names
- "sys" - "sys"
...@@ -42,6 +40,18 @@ Required properties: ...@@ -42,6 +40,18 @@ Required properties:
interrupt source. The value must be 1. interrupt source. The value must be 1.
- interrupt-map-mask and interrupt-map: standard PCI properties - interrupt-map-mask and interrupt-map: standard PCI properties
Required properties for legacy PHY model (deprecated):
- phys: From PHY bindings: Phandle for the Generic PHY for PCIe.
- phy-names: MUST be "pcie-phy".
Required properties for per-lane PHY model (preferred):
- phys: Must contain an phandle to a PHY for each entry in phy-names.
- phy-names: Must include 4 entries for all 4 lanes even if some of
them won't be used for your cases. Entries are of the form "pcie-phy-N":
where N ranges from 0 to 3.
(see example below and you MUST also refer to ../phy/rockchip-pcie-phy.txt
for changing the #phy-cells of phy node to support it)
Optional Property: Optional Property:
- aspm-no-l0s: RC won't support ASPM L0s. This property is needed if - aspm-no-l0s: RC won't support ASPM L0s. This property is needed if
using 24MHz OSC for RC's PHY. using 24MHz OSC for RC's PHY.
...@@ -96,6 +106,7 @@ pcie0: pcie@f8000000 { ...@@ -96,6 +106,7 @@ pcie0: pcie@f8000000 {
<&cru SRST_PCIE_PM>, <&cru SRST_P_PCIE>, <&cru SRST_A_PCIE>; <&cru SRST_PCIE_PM>, <&cru SRST_P_PCIE>, <&cru SRST_A_PCIE>;
reset-names = "core", "mgmt", "mgmt-sticky", "pipe", reset-names = "core", "mgmt", "mgmt-sticky", "pipe",
"pm", "pclk", "aclk"; "pm", "pclk", "aclk";
/* deprecated legacy PHY model */
phys = <&pcie_phy>; phys = <&pcie_phy>;
phy-names = "pcie-phy"; phy-names = "pcie-phy";
pinctrl-names = "default"; pinctrl-names = "default";
...@@ -112,3 +123,13 @@ pcie0: pcie@f8000000 { ...@@ -112,3 +123,13 @@ pcie0: pcie@f8000000 {
#interrupt-cells = <1>; #interrupt-cells = <1>;
}; };
}; };
pcie0: pcie@f8000000 {
...
/* preferred per-lane PHY model */
phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>;
phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3";
...
};
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment