Commit 7a6a731b authored by Bjørn Mork's avatar Bjørn Mork Committed by James Bottomley

[SCSI] megaraid_sas: fix memory leak if SGL has zero length entries

commit 98cb7e44 ([SCSI] megaraid_sas: Sanity check user
supplied length before passing it to dma_alloc_coherent())
introduced a memory leak.  Memory allocated for entries
following zero length SGL entries will not be freed.

Reference: http://bugs.debian.org/688198Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
Cc: <stable@vger.kernel.org>
Acked-by: default avatarAdam Radford <aradford@gmail.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent b2c31107
...@@ -4958,10 +4958,12 @@ megasas_mgmt_fw_ioctl(struct megasas_instance *instance, ...@@ -4958,10 +4958,12 @@ megasas_mgmt_fw_ioctl(struct megasas_instance *instance,
sense, sense_handle); sense, sense_handle);
} }
for (i = 0; i < ioc->sge_count && kbuff_arr[i]; i++) { for (i = 0; i < ioc->sge_count; i++) {
dma_free_coherent(&instance->pdev->dev, if (kbuff_arr[i])
kern_sge32[i].length, dma_free_coherent(&instance->pdev->dev,
kbuff_arr[i], kern_sge32[i].phys_addr); kern_sge32[i].length,
kbuff_arr[i],
kern_sge32[i].phys_addr);
} }
megasas_return_cmd(instance, cmd); megasas_return_cmd(instance, cmd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment