Commit 7a9eeb2f authored by Stefan Richter's avatar Stefan Richter

ieee1394: fix oops on "modprobe -r ohci1394" after network class_device conversion

The networking subsystem has been converted from class_device to device
but ieee1394 hasn't.  This results in a 100% reproducible NULL pointer
dereference if the ohci1394 driver module is unloaded while the eth1394
module is still loaded.
http://lkml.org/lkml/2006/11/16/147
http://lkml.org/lkml/2007/3/14/4

This is a regression in 2.6.21-rc1.
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
Tested-by: default avatarIsmail Dönmez <ismail@pardus.org.tr>
parent 12998096
...@@ -584,7 +584,10 @@ static void ether1394_add_host (struct hpsb_host *host) ...@@ -584,7 +584,10 @@ static void ether1394_add_host (struct hpsb_host *host)
} }
SET_MODULE_OWNER(dev); SET_MODULE_OWNER(dev);
#if 0
/* FIXME - Is this the correct parent device anyway? */
SET_NETDEV_DEV(dev, &host->device); SET_NETDEV_DEV(dev, &host->device);
#endif
priv = netdev_priv(dev); priv = netdev_priv(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment