Commit 7b5bce3a authored by Anton Bondarenko's avatar Anton Bondarenko Committed by Greg Kroah-Hartman

usb: core: fix potential memory leak in error path during hcd creation

commit 1a744d2e upstream.

Free memory allocated for address0_mutex if allocation of bandwidth_mutex
failed.

Fixes: feb26ac3 ("usb: core: hub: hub_port_init lock controller instead of bus")
Signed-off-by: default avatarAnton Bondarenko <anton.bondarenko.sama@gmail.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 12bfbe15
...@@ -2535,6 +2535,7 @@ struct usb_hcd *usb_create_shared_hcd(const struct hc_driver *driver, ...@@ -2535,6 +2535,7 @@ struct usb_hcd *usb_create_shared_hcd(const struct hc_driver *driver,
hcd->bandwidth_mutex = kmalloc(sizeof(*hcd->bandwidth_mutex), hcd->bandwidth_mutex = kmalloc(sizeof(*hcd->bandwidth_mutex),
GFP_KERNEL); GFP_KERNEL);
if (!hcd->bandwidth_mutex) { if (!hcd->bandwidth_mutex) {
kfree(hcd->address0_mutex);
kfree(hcd); kfree(hcd);
dev_dbg(dev, "hcd bandwidth mutex alloc failed\n"); dev_dbg(dev, "hcd bandwidth mutex alloc failed\n");
return NULL; return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment