Commit 7bd49a49 authored by Geordan Neukum's avatar Geordan Neukum Committed by Greg Kroah-Hartman

staging: kpc2000: kpc_i2c: Remove unnecessary function tracing prints

Many of the functions in kpc_i2c log debug-level messages to the
kernel log message buffer upon invocation. This is unnecessary, as
debugging tools like kgdb, kdb, etc. or the tracing tool ftrace
should be able to provide this same information. Therefore, remove
these print statements.
Signed-off-by: default avatarGeordan Neukum <gneukum1@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32806b33
...@@ -139,8 +139,6 @@ static int i801_check_pre(struct i2c_device *priv) ...@@ -139,8 +139,6 @@ static int i801_check_pre(struct i2c_device *priv)
{ {
int status; int status;
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
status = inb_p(SMBHSTSTS(priv)); status = inb_p(SMBHSTSTS(priv));
if (status & SMBHSTSTS_HOST_BUSY) { if (status & SMBHSTSTS_HOST_BUSY) {
dev_err(&priv->adapter.dev, "SMBus is busy, can't use it! (status=%x)\n", status); dev_err(&priv->adapter.dev, "SMBus is busy, can't use it! (status=%x)\n", status);
...@@ -165,8 +163,6 @@ static int i801_check_post(struct i2c_device *priv, int status, int timeout) ...@@ -165,8 +163,6 @@ static int i801_check_post(struct i2c_device *priv, int status, int timeout)
{ {
int result = 0; int result = 0;
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
/* If the SMBus is still busy, we give up */ /* If the SMBus is still busy, we give up */
if (timeout) { if (timeout) {
dev_err(&priv->adapter.dev, "Transaction timeout\n"); dev_err(&priv->adapter.dev, "Transaction timeout\n");
...@@ -214,8 +210,6 @@ static int i801_transaction(struct i2c_device *priv, int xact) ...@@ -214,8 +210,6 @@ static int i801_transaction(struct i2c_device *priv, int xact)
int result; int result;
int timeout = 0; int timeout = 0;
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
result = i801_check_pre(priv); result = i801_check_pre(priv);
if (result < 0) if (result < 0)
return result; return result;
...@@ -244,8 +238,6 @@ static void i801_wait_hwpec(struct i2c_device *priv) ...@@ -244,8 +238,6 @@ static void i801_wait_hwpec(struct i2c_device *priv)
int timeout = 0; int timeout = 0;
int status; int status;
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
do { do {
usleep_range(250, 500); usleep_range(250, 500);
status = inb_p(SMBHSTSTS(priv)); status = inb_p(SMBHSTSTS(priv));
...@@ -262,8 +254,6 @@ static int i801_block_transaction_by_block(struct i2c_device *priv, union i2c_sm ...@@ -262,8 +254,6 @@ static int i801_block_transaction_by_block(struct i2c_device *priv, union i2c_sm
int i, len; int i, len;
int status; int status;
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
inb_p(SMBHSTCNT(priv)); /* reset the data buffer index */ inb_p(SMBHSTCNT(priv)); /* reset the data buffer index */
/* Use 32-byte buffer to process this transaction */ /* Use 32-byte buffer to process this transaction */
...@@ -298,8 +288,6 @@ static int i801_block_transaction_byte_by_byte(struct i2c_device *priv, union i2 ...@@ -298,8 +288,6 @@ static int i801_block_transaction_byte_by_byte(struct i2c_device *priv, union i2
int result; int result;
int timeout; int timeout;
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
result = i801_check_pre(priv); result = i801_check_pre(priv);
if (result < 0) if (result < 0)
return result; return result;
...@@ -364,8 +352,6 @@ static int i801_block_transaction_byte_by_byte(struct i2c_device *priv, union i2 ...@@ -364,8 +352,6 @@ static int i801_block_transaction_byte_by_byte(struct i2c_device *priv, union i2
static int i801_set_block_buffer_mode(struct i2c_device *priv) static int i801_set_block_buffer_mode(struct i2c_device *priv)
{ {
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
outb_p(inb_p(SMBAUXCTL(priv)) | SMBAUXCTL_E32B, SMBAUXCTL(priv)); outb_p(inb_p(SMBAUXCTL(priv)) | SMBAUXCTL_E32B, SMBAUXCTL(priv));
if ((inb_p(SMBAUXCTL(priv)) & SMBAUXCTL_E32B) == 0) if ((inb_p(SMBAUXCTL(priv)) & SMBAUXCTL_E32B) == 0)
return -EIO; return -EIO;
...@@ -378,8 +364,6 @@ static int i801_block_transaction(struct i2c_device *priv, union i2c_smbus_data ...@@ -378,8 +364,6 @@ static int i801_block_transaction(struct i2c_device *priv, union i2c_smbus_data
int result = 0; int result = 0;
//unsigned char hostc; //unsigned char hostc;
dev_dbg(&priv->adapter.dev, "%s\n", __func__);
if (command == I2C_SMBUS_I2C_BLOCK_DATA) { if (command == I2C_SMBUS_I2C_BLOCK_DATA) {
if (read_write == I2C_SMBUS_WRITE) { if (read_write == I2C_SMBUS_WRITE) {
/* set I2C_EN bit in configuration register */ /* set I2C_EN bit in configuration register */
...@@ -427,10 +411,6 @@ static s32 i801_access(struct i2c_adapter *adap, u16 addr, unsigned short flags, ...@@ -427,10 +411,6 @@ static s32 i801_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,
int ret, xact = 0; int ret, xact = 0;
struct i2c_device *priv = i2c_get_adapdata(adap); struct i2c_device *priv = i2c_get_adapdata(adap);
dev_dbg(&priv->adapter.dev,
"%s (addr=%0d) flags=%x read_write=%x command=%x size=%x",
__func__, addr, flags, read_write, command, size);
hwpec = (priv->features & FEATURE_SMBUS_PEC) && (flags & I2C_CLIENT_PEC) && size != I2C_SMBUS_QUICK && size != I2C_SMBUS_I2C_BLOCK_DATA; hwpec = (priv->features & FEATURE_SMBUS_PEC) && (flags & I2C_CLIENT_PEC) && size != I2C_SMBUS_QUICK && size != I2C_SMBUS_I2C_BLOCK_DATA;
switch (size) { switch (size) {
...@@ -605,9 +585,6 @@ int pi2c_probe(struct platform_device *pldev) ...@@ -605,9 +585,6 @@ int pi2c_probe(struct platform_device *pldev)
struct i2c_device *priv; struct i2c_device *priv;
struct resource *res; struct resource *res;
dev_dbg(&pldev->dev, "%s(pldev = %p '%s')\n", __func__, pldev,
pldev->name);
priv = devm_kzalloc(&pldev->dev, sizeof(*priv), GFP_KERNEL); priv = devm_kzalloc(&pldev->dev, sizeof(*priv), GFP_KERNEL);
if (!priv) if (!priv)
return -ENOMEM; return -ENOMEM;
...@@ -653,9 +630,6 @@ int pi2c_remove(struct platform_device *pldev) ...@@ -653,9 +630,6 @@ int pi2c_remove(struct platform_device *pldev)
{ {
struct i2c_device *lddev; struct i2c_device *lddev;
dev_dbg(&pldev->dev, "%s(pldev = %p '%s')\n", __func__, pldev,
pldev->name);
lddev = (struct i2c_device *)pldev->dev.platform_data; lddev = (struct i2c_device *)pldev->dev.platform_data;
i2c_del_adapter(&lddev->adapter); i2c_del_adapter(&lddev->adapter);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment