Commit 7be05753 authored by Selvin Xavier's avatar Selvin Xavier Committed by Doug Ledford

RDMA: Fix return value check for ib_get_eth_speed()

ib_get_eth_speed() return 0 on success. Fixing the condition checking
and prevent reporting failure for query_port verb.

Fixes: d4186194 ("Add generic function to extract IB speed from netdev")
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 0c98568c
...@@ -264,8 +264,8 @@ int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num, ...@@ -264,8 +264,8 @@ int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num,
* IB stack to avoid race in the NETDEV_UNREG path * IB stack to avoid race in the NETDEV_UNREG path
*/ */
if (test_bit(BNXT_RE_FLAG_IBDEV_REGISTERED, &rdev->flags)) if (test_bit(BNXT_RE_FLAG_IBDEV_REGISTERED, &rdev->flags))
if (!ib_get_eth_speed(ibdev, port_num, &port_attr->active_speed, if (ib_get_eth_speed(ibdev, port_num, &port_attr->active_speed,
&port_attr->active_width)) &port_attr->active_width))
return -EINVAL; return -EINVAL;
return 0; return 0;
} }
......
...@@ -309,8 +309,8 @@ int usnic_ib_query_port(struct ib_device *ibdev, u8 port, ...@@ -309,8 +309,8 @@ int usnic_ib_query_port(struct ib_device *ibdev, u8 port,
usnic_dbg("\n"); usnic_dbg("\n");
mutex_lock(&us_ibdev->usdev_lock); mutex_lock(&us_ibdev->usdev_lock);
if (!ib_get_eth_speed(ibdev, port, &props->active_speed, if (ib_get_eth_speed(ibdev, port, &props->active_speed,
&props->active_width)) { &props->active_width)) {
mutex_unlock(&us_ibdev->usdev_lock); mutex_unlock(&us_ibdev->usdev_lock);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment