Commit 7bfd82bf authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Kalle Valo

ath10k: remove unnecessary comparison of unsigned integer with < 0

There is no need to compare *ps_state_enable* with < 0 because
such variable is of type u8 (8 bits, unsigned), making it
impossible to hold a negative value.

Fix this by removing such comparison.

Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 9d9cdbf3
...@@ -2421,7 +2421,7 @@ static ssize_t ath10k_write_ps_state_enable(struct file *file, ...@@ -2421,7 +2421,7 @@ static ssize_t ath10k_write_ps_state_enable(struct file *file,
if (kstrtou8_from_user(user_buf, count, 0, &ps_state_enable)) if (kstrtou8_from_user(user_buf, count, 0, &ps_state_enable))
return -EINVAL; return -EINVAL;
if (ps_state_enable > 1 || ps_state_enable < 0) if (ps_state_enable > 1)
return -EINVAL; return -EINVAL;
mutex_lock(&ar->conf_mutex); mutex_lock(&ar->conf_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment