Commit 7c32ae35 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: seq: Cover unsubscribe_port() in list_mutex

The call of unsubscribe_port() which manages the group count and
module refcount from delete_and_unsubscribe_port() looks racy; it's
not covered by the group list lock, and it's likely a cause of the
reported unbalance at port deletion.  Let's move the call inside the
group list_mutex to plug the hole.

Reported-by: syzbot+e4c8abb920efa77bace9@syzkaller.appspotmail.com
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f0654ba9
...@@ -547,10 +547,10 @@ static void delete_and_unsubscribe_port(struct snd_seq_client *client, ...@@ -547,10 +547,10 @@ static void delete_and_unsubscribe_port(struct snd_seq_client *client,
list_del_init(list); list_del_init(list);
grp->exclusive = 0; grp->exclusive = 0;
write_unlock_irq(&grp->list_lock); write_unlock_irq(&grp->list_lock);
up_write(&grp->list_mutex);
if (!empty) if (!empty)
unsubscribe_port(client, port, grp, &subs->info, ack); unsubscribe_port(client, port, grp, &subs->info, ack);
up_write(&grp->list_mutex);
} }
/* connect two ports */ /* connect two ports */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment