Commit 7c4180b1 authored by Maxime Ripard's avatar Maxime Ripard

drm/sun4i: tv: Rename error label

The other error labels in sun4i_tv_bind() are named after the task they
perform (err_disable_clk to call clk_disable_unprepare for example).

However, the err_cleanup_connector is named after the calling site
(drm_connector_init failing) and will actually cleanup the encoder. Let's
rename it to err_cleanup_encoder to be consistent.
Reviewed-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220728-rpi-analog-tv-properties-v2-39-459522d653a7@cerno.tech
parent 18294b74
...@@ -585,7 +585,7 @@ static int sun4i_tv_bind(struct device *dev, struct device *master, ...@@ -585,7 +585,7 @@ static int sun4i_tv_bind(struct device *dev, struct device *master,
if (ret) { if (ret) {
dev_err(dev, dev_err(dev,
"Couldn't initialise the Composite connector\n"); "Couldn't initialise the Composite connector\n");
goto err_cleanup_connector; goto err_cleanup_encoder;
} }
tv->connector.interlace_allowed = true; tv->connector.interlace_allowed = true;
...@@ -593,7 +593,7 @@ static int sun4i_tv_bind(struct device *dev, struct device *master, ...@@ -593,7 +593,7 @@ static int sun4i_tv_bind(struct device *dev, struct device *master,
return 0; return 0;
err_cleanup_connector: err_cleanup_encoder:
drm_encoder_cleanup(&tv->encoder); drm_encoder_cleanup(&tv->encoder);
err_disable_clk: err_disable_clk:
clk_disable_unprepare(tv->clk); clk_disable_unprepare(tv->clk);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment