Commit 7c5b019e authored by Tony Jones's avatar Tony Jones Committed by Arnaldo Carvalho de Melo

tools lib traceevent: Fix buffer overflow in arg_eval

Fix buffer overflow observed when running perf test.

The overflow is when trying to evaluate "1ULL << (64 - 1)" which is
resulting in -9223372036854775808 which overflows the 20 character
buffer.

If is possible this bug has been reported before but I still don't see
any fix checked in:

See: https://www.spinics.net/lists/linux-perf-users/msg07714.htmlReported-by: default avatarMichael Sartain <mikesart@fastmail.com>
Reported-by: default avatarMathias Krause <minipli@googlemail.com>
Signed-off-by: default avatarTony Jones <tonyj@suse.de>
Acked-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Fixes: f7d82350 ("tools/events: Add files to create libtraceevent.a")
Link: http://lkml.kernel.org/r/20190228015532.8941-1-tonyj@suse.deSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 4d6101f5
...@@ -2457,7 +2457,7 @@ static int arg_num_eval(struct tep_print_arg *arg, long long *val) ...@@ -2457,7 +2457,7 @@ static int arg_num_eval(struct tep_print_arg *arg, long long *val)
static char *arg_eval (struct tep_print_arg *arg) static char *arg_eval (struct tep_print_arg *arg)
{ {
long long val; long long val;
static char buf[20]; static char buf[24];
switch (arg->type) { switch (arg->type) {
case TEP_PRINT_ATOM: case TEP_PRINT_ATOM:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment