Commit 7c9864bb authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller

hv_netvsc: do not use VF device if link is down

If the accelerated networking SRIOV VF device has lost carrier
use the synthetic network device which is available as backup
path. This is a rare case since if VF link goes down, normally
the VMBus device will also loose external connectivity as well.
But if the communication is between two VM's on the same host
the VMBus device will still work.
Reported-by: default avatar"Shah, Ashish N" <ashish.n.shah@intel.com>
Fixes: 0c195567 ("netvsc: transparent VF management")
Signed-off-by: default avatarStephen Hemminger <stephen@networkplumber.org>
Reviewed-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 02afa9c6
...@@ -532,12 +532,13 @@ static int netvsc_xmit(struct sk_buff *skb, struct net_device *net, bool xdp_tx) ...@@ -532,12 +532,13 @@ static int netvsc_xmit(struct sk_buff *skb, struct net_device *net, bool xdp_tx)
u32 hash; u32 hash;
struct hv_page_buffer pb[MAX_PAGE_BUFFER_COUNT]; struct hv_page_buffer pb[MAX_PAGE_BUFFER_COUNT];
/* if VF is present and up then redirect packets /* If VF is present and up then redirect packets to it.
* already called with rcu_read_lock_bh * Skip the VF if it is marked down or has no carrier.
* If netpoll is in uses, then VF can not be used either.
*/ */
vf_netdev = rcu_dereference_bh(net_device_ctx->vf_netdev); vf_netdev = rcu_dereference_bh(net_device_ctx->vf_netdev);
if (vf_netdev && netif_running(vf_netdev) && if (vf_netdev && netif_running(vf_netdev) &&
!netpoll_tx_running(net)) netif_carrier_ok(vf_netdev) && !netpoll_tx_running(net))
return netvsc_vf_xmit(net, vf_netdev, skb); return netvsc_vf_xmit(net, vf_netdev, skb);
/* We will atmost need two pages to describe the rndis /* We will atmost need two pages to describe the rndis
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment