Commit 7c9989a7 authored by Dan Carpenter's avatar Dan Carpenter Committed by Simon Horman

IPVS: precedence bug in ip_vs_sync_switch_mode()

'!' has higher precedence than '&'.  IP_VS_STATE_MASTER is 0x1 so
the original code is equivelent to if (!ipvs->sync_state) ...
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarHans Schillstrom <hans.schillstrom@ericsson.com>
Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
parent 8525d6f8
...@@ -392,7 +392,7 @@ void ip_vs_sync_switch_mode(struct net *net, int mode) ...@@ -392,7 +392,7 @@ void ip_vs_sync_switch_mode(struct net *net, int mode)
{ {
struct netns_ipvs *ipvs = net_ipvs(net); struct netns_ipvs *ipvs = net_ipvs(net);
if (!ipvs->sync_state & IP_VS_STATE_MASTER) if (!(ipvs->sync_state & IP_VS_STATE_MASTER))
return; return;
if (mode == ipvs->sysctl_sync_ver || !ipvs->sync_buff) if (mode == ipvs->sysctl_sync_ver || !ipvs->sync_buff)
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment