Commit 7cc8f2d5 authored by Huacai Chen's avatar Huacai Chen Committed by Thomas Bogendoerfer

MIPS: perf: Remove unnecessary "fallthrough" pseudo keywords

The last branch of switch-case doesn't need a "fallthrough" pseudo
keyword, and it will cause errors when building a kernel with -Werror:

   arch/mips/kernel/perf_event_mipsxx.c: In function 'reset_counters':
   include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
     200 | # define fallthrough                    __attribute__((__fallthrough__))
         |                                         ^~~~~~~~~~~~~
>> arch/mips/kernel/perf_event_mipsxx.c:932:3: note: in expansion of macro 'fallthrough'
     932 |   fallthrough;
         |   ^~~~~~~~~~~
   arch/mips/kernel/perf_event_mipsxx.c: In function 'loongson3_reset_counters':
   include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
     200 | # define fallthrough                    __attribute__((__fallthrough__))
         |                                         ^~~~~~~~~~~~~
   arch/mips/kernel/perf_event_mipsxx.c:903:3: note: in expansion of macro 'fallthrough'
     903 |   fallthrough;
         |   ^~~~~~~~~~~
   cc1: all warnings being treated as errors

Fix it by removing unnecessary "fallthrough" pseudo keywords.

Fixes: e9dfbaae ("MIPS: perf: Add hardware perf events support for new Loongson-3")
Reported-by: default avatarkbuild test robot <lkp@intel.com>
Signed-off-by: default avatarHuacai Chen <chenhc@lemote.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 9d139131
...@@ -900,7 +900,7 @@ static void loongson3_reset_counters(void *arg) ...@@ -900,7 +900,7 @@ static void loongson3_reset_counters(void *arg)
mipspmu.write_counter(0, 0); mipspmu.write_counter(0, 0);
mipsxx_pmu_write_control(0, 575<<5); mipsxx_pmu_write_control(0, 575<<5);
mipspmu.write_counter(0, 0); mipspmu.write_counter(0, 0);
fallthrough; break;
} }
} }
...@@ -929,7 +929,7 @@ static void reset_counters(void *arg) ...@@ -929,7 +929,7 @@ static void reset_counters(void *arg)
case 1: case 1:
mipsxx_pmu_write_control(0, 0); mipsxx_pmu_write_control(0, 0);
mipspmu.write_counter(0, 0); mipspmu.write_counter(0, 0);
fallthrough; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment