Commit 7cecb47f authored by Ben Hutchings's avatar Ben Hutchings Committed by Rafael J. Wysocki

ACPI / extlog: Check for RDMSR failure

extlog_init() uses rdmsrl() to read an MSR, which on older CPUs
provokes a error message at boot:

    unchecked MSR access error: RDMSR from 0x179 at rIP: 0xcd047307 (native_read_msr+0x7/0x40)

Use rdmsrl_safe() instead, and return -ENODEV if it fails.

Reported-by: jim@photojim.ca
References: https://bugs.debian.org/971058
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent a1b8638b
...@@ -222,9 +222,9 @@ static int __init extlog_init(void) ...@@ -222,9 +222,9 @@ static int __init extlog_init(void)
u64 cap; u64 cap;
int rc; int rc;
rdmsrl(MSR_IA32_MCG_CAP, cap); if (rdmsrl_safe(MSR_IA32_MCG_CAP, &cap) ||
!(cap & MCG_ELOG_P) ||
if (!(cap & MCG_ELOG_P) || !extlog_get_l1addr()) !extlog_get_l1addr())
return -ENODEV; return -ENODEV;
rc = -EINVAL; rc = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment