Commit 7cf61de7 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman

tty: goldfish: drop unneeded temporary variables

We can pass 'buf' directly to goldfish_tty_rw() using simple (unsigned
long) cast. There is no need to obfuscate the code by another variable
with double casts.
Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20231121092258.9334-9-jirislaby@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9d3e3301
...@@ -128,16 +128,14 @@ static void goldfish_tty_rw(struct goldfish_tty *qtty, ...@@ -128,16 +128,14 @@ static void goldfish_tty_rw(struct goldfish_tty *qtty,
static void goldfish_tty_do_write(int line, const u8 *buf, unsigned int count) static void goldfish_tty_do_write(int line, const u8 *buf, unsigned int count)
{ {
struct goldfish_tty *qtty = &goldfish_ttys[line]; struct goldfish_tty *qtty = &goldfish_ttys[line];
unsigned long address = (unsigned long)(void *)buf;
goldfish_tty_rw(qtty, address, count, 1); goldfish_tty_rw(qtty, (unsigned long)buf, count, 1);
} }
static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id) static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
{ {
struct goldfish_tty *qtty = dev_id; struct goldfish_tty *qtty = dev_id;
void __iomem *base = qtty->base; void __iomem *base = qtty->base;
unsigned long address;
unsigned char *buf; unsigned char *buf;
u32 count; u32 count;
...@@ -147,8 +145,7 @@ static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id) ...@@ -147,8 +145,7 @@ static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
count = tty_prepare_flip_string(&qtty->port, &buf, count); count = tty_prepare_flip_string(&qtty->port, &buf, count);
address = (unsigned long)(void *)buf; goldfish_tty_rw(qtty, (unsigned long)buf, count, 0);
goldfish_tty_rw(qtty, address, count, 0);
tty_flip_buffer_push(&qtty->port); tty_flip_buffer_push(&qtty->port);
return IRQ_HANDLED; return IRQ_HANDLED;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment