Commit 7d1fedb6 authored by Vinothkumar Raja's avatar Vinothkumar Raja Committed by Mike Snitzer

dm btree: fix for dm_btree_find_lowest_key()

dm_btree_find_lowest_key() is giving incorrect results.  find_key()
traverses the btree correctly for finding the highest key, but there is
an error in the way it traverses the btree for retrieving the lowest
key.  dm_btree_find_lowest_key() fetches the first key of the rightmost
block of the btree instead of fetching the first key from the leftmost
block.

Fix this by conditionally passing the correct parameter to value64()
based on the @find_highest flag.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarErez Zadok <ezk@fsl.cs.sunysb.edu>
Signed-off-by: default avatarVinothkumar Raja <vinraja@cs.stonybrook.edu>
Signed-off-by: default avatarNidhi Panpalia <npanpalia@cs.stonybrook.edu>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent e36215d8
...@@ -902,8 +902,12 @@ static int find_key(struct ro_spine *s, dm_block_t block, bool find_highest, ...@@ -902,8 +902,12 @@ static int find_key(struct ro_spine *s, dm_block_t block, bool find_highest,
else else
*result_key = le64_to_cpu(ro_node(s)->keys[0]); *result_key = le64_to_cpu(ro_node(s)->keys[0]);
if (next_block || flags & INTERNAL_NODE) if (next_block || flags & INTERNAL_NODE) {
block = value64(ro_node(s), i); if (find_highest)
block = value64(ro_node(s), i);
else
block = value64(ro_node(s), 0);
}
} while (flags & INTERNAL_NODE); } while (flags & INTERNAL_NODE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment