Commit 7da7b02e authored by Aashish Sharma's avatar Aashish Sharma Committed by Alex Deucher

drm/amd/display: Fix unused-but-set-variable warning

Fix the kernel test robot warning below:

drivers/gpu/drm/amd/amdgpu/../display/dmub/inc/dmub_cmd.h:2893:12:
warning: variable 'temp' set but not used [-Wunused-but-set-variable]

Replaced the assignment to the unused temp variable with READ_ONCE()
macro to flush the writes. READ_ONCE() helps avoid the use of
volatile and makes it obvious from the code that the read here is
intentional. Also verified on x86 that the generated code is exactly the
same as before.
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarAashish Sharma <shraash@google.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a68bec2c
...@@ -2962,9 +2962,7 @@ static inline void dmub_rb_flush_pending(const struct dmub_rb *rb) ...@@ -2962,9 +2962,7 @@ static inline void dmub_rb_flush_pending(const struct dmub_rb *rb)
uint32_t wptr = rb->wrpt; uint32_t wptr = rb->wrpt;
while (rptr != wptr) { while (rptr != wptr) {
uint64_t volatile *data = (uint64_t volatile *)((uint8_t *)(rb->base_address) + rptr); uint64_t *data = (uint64_t *)((uint8_t *)(rb->base_address) + rptr);
//uint64_t volatile *p = (uint64_t volatile *)data;
uint64_t temp;
uint8_t i; uint8_t i;
/* Don't remove this. /* Don't remove this.
...@@ -2972,7 +2970,7 @@ static inline void dmub_rb_flush_pending(const struct dmub_rb *rb) ...@@ -2972,7 +2970,7 @@ static inline void dmub_rb_flush_pending(const struct dmub_rb *rb)
* for this function to be effective. * for this function to be effective.
*/ */
for (i = 0; i < DMUB_RB_CMD_SIZE / sizeof(uint64_t); i++) for (i = 0; i < DMUB_RB_CMD_SIZE / sizeof(uint64_t); i++)
temp = *data++; (void)READ_ONCE(*data++);
rptr += DMUB_RB_CMD_SIZE; rptr += DMUB_RB_CMD_SIZE;
if (rptr >= rb->capacity) if (rptr >= rb->capacity)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment