Commit 7dab5467 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Marcel Holtmann

net: ieee802154: fix potential null pointer dereference

Null check at line 918: if (!spi) {, implies spi might be NULL.
Function spi_get_drvdata() dereference pointer spi.
Move pointer priv assignment after the null check.

Addresses-Coverity-ID: 1408888
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent a611c58b
...@@ -912,7 +912,7 @@ static int ca8210_spi_transfer( ...@@ -912,7 +912,7 @@ static int ca8210_spi_transfer(
) )
{ {
int i, status = 0; int i, status = 0;
struct ca8210_priv *priv = spi_get_drvdata(spi); struct ca8210_priv *priv;
struct cas_control *cas_ctl; struct cas_control *cas_ctl;
if (!spi) { if (!spi) {
...@@ -923,6 +923,7 @@ static int ca8210_spi_transfer( ...@@ -923,6 +923,7 @@ static int ca8210_spi_transfer(
return -ENODEV; return -ENODEV;
} }
priv = spi_get_drvdata(spi);
reinit_completion(&priv->spi_transfer_complete); reinit_completion(&priv->spi_transfer_complete);
dev_dbg(&spi->dev, "ca8210_spi_transfer called\n"); dev_dbg(&spi->dev, "ca8210_spi_transfer called\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment