Commit 7dd7a2fd authored by Takashi Iwai's avatar Takashi Iwai

ALSA: au88x0: Give comment for vortex_wtdma_bufshift() issue

The check of the return value from vortex_wtdma_bufshft() in
vortex_interrupt() is useless as it executes no code.  Actually the
return value is intentionally ignored because the delta calculation
for wavetable doesn't work always correctly.  For avoiding the
confusion, a comment is added and the superfluous if () is removed.
Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f598158a
......@@ -2461,7 +2461,12 @@ static irqreturn_t vortex_interrupt(int irq, void *dev_id)
#ifndef CHIP_AU8810
for (i = 0; i < NR_WT; i++) {
if (vortex->dma_wt[i].fifo_status == FIFO_START) {
if (vortex_wtdma_bufshift(vortex, i)) ;
/* FIXME: we ignore the return value from
* vortex_wtdma_bufshift() below as the delta
* calculation seems not working for wavetable
* by some reason
*/
vortex_wtdma_bufshift(vortex, i);
spin_unlock(&vortex->lock);
snd_pcm_period_elapsed(vortex->dma_wt[i].
substream);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment