Commit 7e05c8de authored by Lee Jones's avatar Lee Jones Committed by Bjorn Andersson

remoteproc: remoteproc_core: Use 'gnu_printf' format notation

Fixes the following W=1 kernel build warning(s):

 drivers/remoteproc/remoteproc_core.c: In function ‘rproc_find_carveout_by_name’:
 drivers/remoteproc/remoteproc_core.c:257:2: warning: function ‘rproc_find_carveout_by_name’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
 257 | vsnprintf(_name, sizeof(_name), name, args);
 | ^~~~~~~~~
 drivers/remoteproc/remoteproc_core.c: In function ‘rproc_mem_entry_init’:
 drivers/remoteproc/remoteproc_core.c:993:2: warning: function ‘rproc_mem_entry_init’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
 993 | vsnprintf(mem->name, sizeof(mem->name), name, args);
 | ^~~~~~~~~
 drivers/remoteproc/remoteproc_core.c: In function ‘rproc_of_resm_mem_entry_init’:
 drivers/remoteproc/remoteproc_core.c:1029:2: warning: function ‘rproc_of_resm_mem_entry_init’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
 1029 | vsnprintf(mem->name, sizeof(mem->name), name, args);
 | ^~~~~~~~~

Cc: Brian Swetland <swetland@google.com>
Cc: Mark Grosen <mgrosen@ti.com>
Cc: Guzman Lugo <fernando.lugo@ti.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Robert Tivy <rtivy@ti.com>
Cc: De Leon <x0095078@ti.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200715123551.4011154-1-lee.jones@linaro.orgSigned-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 0cf17702
...@@ -243,6 +243,7 @@ EXPORT_SYMBOL(rproc_da_to_va); ...@@ -243,6 +243,7 @@ EXPORT_SYMBOL(rproc_da_to_va);
* *
* Return: a valid pointer on carveout entry on success or NULL on failure. * Return: a valid pointer on carveout entry on success or NULL on failure.
*/ */
__printf(2, 3)
struct rproc_mem_entry * struct rproc_mem_entry *
rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...) rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...)
{ {
...@@ -966,6 +967,7 @@ EXPORT_SYMBOL(rproc_add_carveout); ...@@ -966,6 +967,7 @@ EXPORT_SYMBOL(rproc_add_carveout);
* This function allocates a rproc_mem_entry struct and fill it with parameters * This function allocates a rproc_mem_entry struct and fill it with parameters
* provided by client. * provided by client.
*/ */
__printf(8, 9)
struct rproc_mem_entry * struct rproc_mem_entry *
rproc_mem_entry_init(struct device *dev, rproc_mem_entry_init(struct device *dev,
void *va, dma_addr_t dma, size_t len, u32 da, void *va, dma_addr_t dma, size_t len, u32 da,
...@@ -1009,6 +1011,7 @@ EXPORT_SYMBOL(rproc_mem_entry_init); ...@@ -1009,6 +1011,7 @@ EXPORT_SYMBOL(rproc_mem_entry_init);
* This function allocates a rproc_mem_entry struct and fill it with parameters * This function allocates a rproc_mem_entry struct and fill it with parameters
* provided by client. * provided by client.
*/ */
__printf(5, 6)
struct rproc_mem_entry * struct rproc_mem_entry *
rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, size_t len, rproc_of_resm_mem_entry_init(struct device *dev, u32 of_resm_idx, size_t len,
u32 da, const char *name, ...) u32 da, const char *name, ...)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment