Commit 7e28abda authored by Wei Yongjun's avatar Wei Yongjun Committed by Lee Jones

mfd: hi655x: Fix return value check in hi655x_pmic_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR(). Also remove unneeded error handling of
platform_get_resource().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 4dc03d0a
...@@ -105,12 +105,9 @@ static int hi655x_pmic_probe(struct platform_device *pdev) ...@@ -105,12 +105,9 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
pmic->dev = dev; pmic->dev = dev;
pmic->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); pmic->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!pmic->res)
return -ENOENT;
base = devm_ioremap_resource(dev, pmic->res); base = devm_ioremap_resource(dev, pmic->res);
if (!base) if (IS_ERR(base))
return -ENOMEM; return PTR_ERR(base);
pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base, pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
&hi655x_regmap_config); &hi655x_regmap_config);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment