Commit 7fc1609b authored by Martin Blumenstingl's avatar Martin Blumenstingl Committed by Neil Armstrong

clk: meson: meson8b: allow changing the CPU clock tree

Currently all clocks in the CPU clock tree are marked as read-only
(using the corresponding _ro_ clk_ops). This was correct since changing
the clock tree could cause the system to lock up.
Switch all clocks to their corresponding clk_ops variant which is not
read-only to allow changing the CPU clock tree since the bug which
locked up the system is now fixed (by switching the CPU clock temporary
to run off XTAL while changing the CPU clock tree).
Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Signed-off-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Link: https://lkml.kernel.org/r/20181115224048.13511-7-martin.blumenstingl@googlemail.com
parent 7dc7eeb8
...@@ -203,7 +203,7 @@ static struct clk_regmap meson8b_sys_pll_dco = { ...@@ -203,7 +203,7 @@ static struct clk_regmap meson8b_sys_pll_dco = {
}, },
.hw.init = &(struct clk_init_data){ .hw.init = &(struct clk_init_data){
.name = "sys_pll_dco", .name = "sys_pll_dco",
.ops = &meson_clk_pll_ro_ops, .ops = &meson_clk_pll_ops,
.parent_names = (const char *[]){ "xtal" }, .parent_names = (const char *[]){ "xtal" },
.num_parents = 1, .num_parents = 1,
}, },
...@@ -218,7 +218,7 @@ static struct clk_regmap meson8b_sys_pll = { ...@@ -218,7 +218,7 @@ static struct clk_regmap meson8b_sys_pll = {
}, },
.hw.init = &(struct clk_init_data){ .hw.init = &(struct clk_init_data){
.name = "sys_pll", .name = "sys_pll",
.ops = &clk_regmap_divider_ro_ops, .ops = &clk_regmap_divider_ops,
.parent_names = (const char *[]){ "sys_pll_dco" }, .parent_names = (const char *[]){ "sys_pll_dco" },
.num_parents = 1, .num_parents = 1,
.flags = CLK_SET_RATE_PARENT, .flags = CLK_SET_RATE_PARENT,
...@@ -552,7 +552,7 @@ static struct clk_regmap meson8b_cpu_in_sel = { ...@@ -552,7 +552,7 @@ static struct clk_regmap meson8b_cpu_in_sel = {
}, },
.hw.init = &(struct clk_init_data){ .hw.init = &(struct clk_init_data){
.name = "cpu_in_sel", .name = "cpu_in_sel",
.ops = &clk_regmap_mux_ro_ops, .ops = &clk_regmap_mux_ops,
.parent_names = (const char *[]){ "xtal", "sys_pll" }, .parent_names = (const char *[]){ "xtal", "sys_pll" },
.num_parents = 2, .num_parents = 2,
.flags = (CLK_SET_RATE_PARENT | .flags = (CLK_SET_RATE_PARENT |
...@@ -606,7 +606,7 @@ static struct clk_regmap meson8b_cpu_scale_div = { ...@@ -606,7 +606,7 @@ static struct clk_regmap meson8b_cpu_scale_div = {
}, },
.hw.init = &(struct clk_init_data){ .hw.init = &(struct clk_init_data){
.name = "cpu_scale_div", .name = "cpu_scale_div",
.ops = &clk_regmap_divider_ro_ops, .ops = &clk_regmap_divider_ops,
.parent_names = (const char *[]){ "cpu_in_sel" }, .parent_names = (const char *[]){ "cpu_in_sel" },
.num_parents = 1, .num_parents = 1,
.flags = CLK_SET_RATE_PARENT, .flags = CLK_SET_RATE_PARENT,
...@@ -623,7 +623,7 @@ static struct clk_regmap meson8b_cpu_scale_out_sel = { ...@@ -623,7 +623,7 @@ static struct clk_regmap meson8b_cpu_scale_out_sel = {
}, },
.hw.init = &(struct clk_init_data){ .hw.init = &(struct clk_init_data){
.name = "cpu_scale_out_sel", .name = "cpu_scale_out_sel",
.ops = &clk_regmap_mux_ro_ops, .ops = &clk_regmap_mux_ops,
/* /*
* NOTE: We are skipping the parent with value 0x2 (which is * NOTE: We are skipping the parent with value 0x2 (which is
* "cpu_div3") because it results in a duty cycle of 33% which * "cpu_div3") because it results in a duty cycle of 33% which
...@@ -646,7 +646,7 @@ static struct clk_regmap meson8b_cpu_clk = { ...@@ -646,7 +646,7 @@ static struct clk_regmap meson8b_cpu_clk = {
}, },
.hw.init = &(struct clk_init_data){ .hw.init = &(struct clk_init_data){
.name = "cpu_clk", .name = "cpu_clk",
.ops = &clk_regmap_mux_ro_ops, .ops = &clk_regmap_mux_ops,
.parent_names = (const char *[]){ "xtal", .parent_names = (const char *[]){ "xtal",
"cpu_scale_out_sel" }, "cpu_scale_out_sel" },
.num_parents = 2, .num_parents = 2,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment