Commit 7fdc7766 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski

Revert "net: phy: meson-gxl: improve link-up behavior"

This reverts commit 2c87c6f9.
Meanwhile it turned out that the following commit is the proper
workaround for the issue that 2c87c6f9 tries to address.
a3a57bf0 ("net: stmmac: work around sporadic tx issue on link-up")
It's nor clear why the to be reverted commit helped for one user,
for others it didn't make a difference.

Fixes: 2c87c6f9 ("net: phy: meson-gxl: improve link-up behavior")
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/8deeeddc-6b71-129b-1918-495a12dc11e3@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 42e66b1c
...@@ -243,13 +243,7 @@ static irqreturn_t meson_gxl_handle_interrupt(struct phy_device *phydev) ...@@ -243,13 +243,7 @@ static irqreturn_t meson_gxl_handle_interrupt(struct phy_device *phydev)
irq_status == INTSRC_ENERGY_DETECT) irq_status == INTSRC_ENERGY_DETECT)
return IRQ_HANDLED; return IRQ_HANDLED;
/* Give PHY some time before MAC starts sending data. This works phy_trigger_machine(phydev);
* around an issue where network doesn't come up properly.
*/
if (!(irq_status & INTSRC_LINK_DOWN))
phy_queue_state_machine(phydev, msecs_to_jiffies(100));
else
phy_trigger_machine(phydev);
return IRQ_HANDLED; return IRQ_HANDLED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment