Commit 80e4232e authored by Szymon Janc's avatar Szymon Janc Committed by Samuel Ortiz

NFC: Small nfc_hci_create_pipe refactoring

Check for error and return if any. This makes it easier to see what is
a 'positive' function flow.
Signed-off-by: default avatarSzymon Janc <szymon.janc@tieto.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 36b05114
...@@ -257,16 +257,16 @@ static u8 nfc_hci_create_pipe(struct nfc_hci_dev *hdev, u8 dest_host, ...@@ -257,16 +257,16 @@ static u8 nfc_hci_create_pipe(struct nfc_hci_dev *hdev, u8 dest_host,
*result = nfc_hci_execute_cmd(hdev, NFC_HCI_ADMIN_PIPE, *result = nfc_hci_execute_cmd(hdev, NFC_HCI_ADMIN_PIPE,
NFC_HCI_ADM_CREATE_PIPE, NFC_HCI_ADM_CREATE_PIPE,
(u8 *) &params, sizeof(params), &skb); (u8 *) &params, sizeof(params), &skb);
if (*result == 0) { if (*result < 0)
resp = (struct hci_create_pipe_resp *)skb->data; return NFC_HCI_INVALID_PIPE;
pipe = resp->pipe;
kfree_skb(skb);
pr_debug("pipe created=%d\n", pipe); resp = (struct hci_create_pipe_resp *)skb->data;
pipe = resp->pipe;
kfree_skb(skb);
return pipe; pr_debug("pipe created=%d\n", pipe);
} else
return NFC_HCI_INVALID_PIPE; return pipe;
} }
static int nfc_hci_delete_pipe(struct nfc_hci_dev *hdev, u8 pipe) static int nfc_hci_delete_pipe(struct nfc_hci_dev *hdev, u8 pipe)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment