Commit 8134233e authored by Dan Carpenter's avatar Dan Carpenter Committed by Tejun Heo

ata: ahci_xgene: dereferencing uninitialized pointer in probe

If the call to acpi_get_object_info() fails then "info" hasn't been
initialized.  In that situation, we already know that "version" should
be XGENE_AHCI_V1 so we don't actually need to dereference "info".

Fixes: c9802a4b ('ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 8ba559fd
...@@ -821,9 +821,9 @@ static int xgene_ahci_probe(struct platform_device *pdev) ...@@ -821,9 +821,9 @@ static int xgene_ahci_probe(struct platform_device *pdev)
dev_warn(&pdev->dev, "%s: Error reading device info. Assume version1\n", dev_warn(&pdev->dev, "%s: Error reading device info. Assume version1\n",
__func__); __func__);
version = XGENE_AHCI_V1; version = XGENE_AHCI_V1;
} } else if (info->valid & ACPI_VALID_CID) {
if (info->valid & ACPI_VALID_CID)
version = XGENE_AHCI_V2; version = XGENE_AHCI_V2;
}
} }
} }
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment