Commit 816ac3e6 authored by Felix Fietkau's avatar Felix Fietkau Committed by David S. Miller

net: ethernet: mtk_eth_soc: only read the full RX descriptor if DMA is done

Uncached memory access is expensive, and there is no need to access all
descriptor words if we can't process them anyway
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
Signed-off-by: default avatarIlya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4e6bf609
...@@ -777,13 +777,18 @@ static inline int mtk_max_buf_size(int frag_size) ...@@ -777,13 +777,18 @@ static inline int mtk_max_buf_size(int frag_size)
return buf_size; return buf_size;
} }
static inline void mtk_rx_get_desc(struct mtk_rx_dma *rxd, static inline bool mtk_rx_get_desc(struct mtk_rx_dma *rxd,
struct mtk_rx_dma *dma_rxd) struct mtk_rx_dma *dma_rxd)
{ {
rxd->rxd1 = READ_ONCE(dma_rxd->rxd1);
rxd->rxd2 = READ_ONCE(dma_rxd->rxd2); rxd->rxd2 = READ_ONCE(dma_rxd->rxd2);
if (!(rxd->rxd2 & RX_DMA_DONE))
return false;
rxd->rxd1 = READ_ONCE(dma_rxd->rxd1);
rxd->rxd3 = READ_ONCE(dma_rxd->rxd3); rxd->rxd3 = READ_ONCE(dma_rxd->rxd3);
rxd->rxd4 = READ_ONCE(dma_rxd->rxd4); rxd->rxd4 = READ_ONCE(dma_rxd->rxd4);
return true;
} }
/* the qdma core needs scratch memory to be setup */ /* the qdma core needs scratch memory to be setup */
...@@ -1255,8 +1260,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, ...@@ -1255,8 +1260,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
rxd = &ring->dma[idx]; rxd = &ring->dma[idx];
data = ring->data[idx]; data = ring->data[idx];
mtk_rx_get_desc(&trxd, rxd); if (!mtk_rx_get_desc(&trxd, rxd))
if (!(trxd.rxd2 & RX_DMA_DONE))
break; break;
/* find out which mac the packet come from. values start at 1 */ /* find out which mac the packet come from. values start at 1 */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment