Commit 81b9de43 authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Mauro Carvalho Chehab

media: media-device: use strlcpy() instead of strncpy()

gcc-8 reports

drivers/media/media-device.c: In function 'media_device_get_topology':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 64 equals destination size [-Wstringop-truncation]

We need to use strlcpy() to make sure the dest string is nul-terminated.
Signed-off-by: default avatarXiongfeng Wang <xiongfeng.wang@linaro.org>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 66487818
...@@ -255,7 +255,7 @@ static long media_device_get_topology(struct media_device *mdev, ...@@ -255,7 +255,7 @@ static long media_device_get_topology(struct media_device *mdev,
memset(&kentity, 0, sizeof(kentity)); memset(&kentity, 0, sizeof(kentity));
kentity.id = entity->graph_obj.id; kentity.id = entity->graph_obj.id;
kentity.function = entity->function; kentity.function = entity->function;
strncpy(kentity.name, entity->name, strlcpy(kentity.name, entity->name,
sizeof(kentity.name)); sizeof(kentity.name));
if (copy_to_user(uentity, &kentity, sizeof(kentity))) if (copy_to_user(uentity, &kentity, sizeof(kentity)))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment