Commit 821ace29 authored by Vlad Dogaru's avatar Vlad Dogaru Committed by Jonathan Cameron

iio: sx9500: refactor GPIO interrupt code

Signed-off-by: default avatarVlad Dogaru <vlad.dogaru@intel.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 59bd0427
...@@ -32,7 +32,7 @@ ...@@ -32,7 +32,7 @@
#define SX9500_DRIVER_NAME "sx9500" #define SX9500_DRIVER_NAME "sx9500"
#define SX9500_IRQ_NAME "sx9500_event" #define SX9500_IRQ_NAME "sx9500_event"
#define SX9500_GPIO_NAME "interrupt" #define SX9500_GPIO_INT "interrupt"
/* Register definitions. */ /* Register definitions. */
#define SX9500_REG_IRQ_SRC 0x00 #define SX9500_REG_IRQ_SRC 0x00
...@@ -857,30 +857,24 @@ static int sx9500_init_device(struct iio_dev *indio_dev) ...@@ -857,30 +857,24 @@ static int sx9500_init_device(struct iio_dev *indio_dev)
return 0; return 0;
} }
static int sx9500_gpio_probe(struct i2c_client *client, static void sx9500_gpio_probe(struct i2c_client *client,
struct sx9500_data *data) struct sx9500_data *data)
{ {
struct device *dev; struct device *dev;
struct gpio_desc *gpio; struct gpio_desc *gpio;
int ret;
if (!client) if (!client)
return -EINVAL; return;
dev = &client->dev; dev = &client->dev;
/* data ready gpio interrupt pin */ if (client->irq <= 0) {
gpio = devm_gpiod_get_index(dev, SX9500_GPIO_NAME, 0, GPIOD_IN); gpio = devm_gpiod_get_index(dev, SX9500_GPIO_INT, 0, GPIOD_IN);
if (IS_ERR(gpio)) { if (IS_ERR(gpio))
dev_err(dev, "acpi gpio get index failed\n"); dev_err(dev, "gpio get irq failed\n");
return PTR_ERR(gpio); else
client->irq = gpiod_to_irq(gpio);
} }
ret = gpiod_to_irq(gpio);
dev_dbg(dev, "GPIO resource, no:%d irq:%d\n", desc_to_gpio(gpio), ret);
return ret;
} }
static int sx9500_probe(struct i2c_client *client, static int sx9500_probe(struct i2c_client *client,
...@@ -914,8 +908,7 @@ static int sx9500_probe(struct i2c_client *client, ...@@ -914,8 +908,7 @@ static int sx9500_probe(struct i2c_client *client,
indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->modes = INDIO_DIRECT_MODE;
i2c_set_clientdata(client, indio_dev); i2c_set_clientdata(client, indio_dev);
if (client->irq <= 0) sx9500_gpio_probe(client, data);
client->irq = sx9500_gpio_probe(client, data);
if (client->irq <= 0) if (client->irq <= 0)
dev_warn(&client->dev, "no valid irq found\n"); dev_warn(&client->dev, "no valid irq found\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment