Commit 82e2c39f authored by Josua Mayer's avatar Josua Mayer Committed by Jakub Kicinski

net: phy: dp83869: fix default value for tx-/rx-internal-delay

dp83869 internally uses a look-up table for mapping supported delays in
nanoseconds to register values.
When specific delays are defined in device-tree, phy_get_internal_delay
does the lookup automatically returning an index.

The default case wrongly assigns the nanoseconds value from the lookup
table, resulting in numeric value 2000 applied to delay configuration
register, rather than the expected index values 0-7 (7 for 2000).
Ultimately this issue broke RX for 1Gbps links.

Fix default delay configuration by assigning the intended index value
directly.

Cc: stable@vger.kernel.org
Fixes: 736b25af ("net: dp83869: Add RGMII internal delay configuration")
Co-developed-by: default avatarYazan Shhady <yazan.shhady@solid-run.com>
Signed-off-by: default avatarYazan Shhady <yazan.shhady@solid-run.com>
Signed-off-by: default avatarJosua Mayer <josua@solid-run.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230323102536.31988-1-josua@solid-run.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ca4a80e4
...@@ -588,15 +588,13 @@ static int dp83869_of_init(struct phy_device *phydev) ...@@ -588,15 +588,13 @@ static int dp83869_of_init(struct phy_device *phydev)
&dp83869_internal_delay[0], &dp83869_internal_delay[0],
delay_size, true); delay_size, true);
if (dp83869->rx_int_delay < 0) if (dp83869->rx_int_delay < 0)
dp83869->rx_int_delay = dp83869->rx_int_delay = DP83869_CLK_DELAY_DEF;
dp83869_internal_delay[DP83869_CLK_DELAY_DEF];
dp83869->tx_int_delay = phy_get_internal_delay(phydev, dev, dp83869->tx_int_delay = phy_get_internal_delay(phydev, dev,
&dp83869_internal_delay[0], &dp83869_internal_delay[0],
delay_size, false); delay_size, false);
if (dp83869->tx_int_delay < 0) if (dp83869->tx_int_delay < 0)
dp83869->tx_int_delay = dp83869->tx_int_delay = DP83869_CLK_DELAY_DEF;
dp83869_internal_delay[DP83869_CLK_DELAY_DEF];
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment