Commit 82e9c66e authored by Evan Green's avatar Evan Green Committed by Palmer Dabbelt

RISC-V: Track ISA extensions per hart

The kernel maintains a mask of ISA extensions ANDed together across all
harts. Let's also keep a bitmap of ISA extensions for each CPU. Although
the kernel is currently unlikely to enable a feature that exists only on
some CPUs, we want the ability to report asymmetric CPU extensions
accurately to usermode.

Note that riscv_fill_hwcaps() runs before the per_cpu_offsets are built,
which is why I've used a [NR_CPUS] array rather than per_cpu() data.
Signed-off-by: default avatarEvan Green <evan@rivosinc.com>
Reviewed-by: default avatarAndrew Jones <ajones@ventanamicro.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Reviewed-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
Link: https://lore.kernel.org/r/20230509182504.2997252-3-evan@rivosinc.comSigned-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent c6699baf
...@@ -6,6 +6,9 @@ ...@@ -6,6 +6,9 @@
#ifndef _ASM_CPUFEATURE_H #ifndef _ASM_CPUFEATURE_H
#define _ASM_CPUFEATURE_H #define _ASM_CPUFEATURE_H
#include <linux/bitmap.h>
#include <asm/hwcap.h>
/* /*
* These are probed via a device_initcall(), via either the SBI or directly * These are probed via a device_initcall(), via either the SBI or directly
* from the corresponding CSRs. * from the corresponding CSRs.
...@@ -16,8 +19,15 @@ struct riscv_cpuinfo { ...@@ -16,8 +19,15 @@ struct riscv_cpuinfo {
unsigned long mimpid; unsigned long mimpid;
}; };
struct riscv_isainfo {
DECLARE_BITMAP(isa, RISCV_ISA_EXT_MAX);
};
DECLARE_PER_CPU(struct riscv_cpuinfo, riscv_cpuinfo); DECLARE_PER_CPU(struct riscv_cpuinfo, riscv_cpuinfo);
DECLARE_PER_CPU(long, misaligned_access_speed); DECLARE_PER_CPU(long, misaligned_access_speed);
/* Per-cpu ISA extensions. */
extern struct riscv_isainfo hart_isa[NR_CPUS];
#endif #endif
...@@ -26,6 +26,9 @@ unsigned long elf_hwcap __read_mostly; ...@@ -26,6 +26,9 @@ unsigned long elf_hwcap __read_mostly;
/* Host ISA bitmap */ /* Host ISA bitmap */
static DECLARE_BITMAP(riscv_isa, RISCV_ISA_EXT_MAX) __read_mostly; static DECLARE_BITMAP(riscv_isa, RISCV_ISA_EXT_MAX) __read_mostly;
/* Per-cpu ISA extensions. */
struct riscv_isainfo hart_isa[NR_CPUS];
/* Performance information */ /* Performance information */
DEFINE_PER_CPU(long, misaligned_access_speed); DEFINE_PER_CPU(long, misaligned_access_speed);
...@@ -113,14 +116,18 @@ void __init riscv_fill_hwcap(void) ...@@ -113,14 +116,18 @@ void __init riscv_fill_hwcap(void)
bitmap_zero(riscv_isa, RISCV_ISA_EXT_MAX); bitmap_zero(riscv_isa, RISCV_ISA_EXT_MAX);
for_each_of_cpu_node(node) { for_each_of_cpu_node(node) {
struct riscv_isainfo *isainfo;
unsigned long this_hwcap = 0; unsigned long this_hwcap = 0;
DECLARE_BITMAP(this_isa, RISCV_ISA_EXT_MAX);
const char *temp; const char *temp;
unsigned int cpu_id;
rc = riscv_of_processor_hartid(node, &hartid); rc = riscv_of_processor_hartid(node, &hartid);
if (rc < 0) if (rc < 0)
continue; continue;
cpu_id = riscv_hartid_to_cpuid(hartid);
isainfo = &hart_isa[cpu_id];
if (of_property_read_string(node, "riscv,isa", &isa)) { if (of_property_read_string(node, "riscv,isa", &isa)) {
pr_warn("Unable to find \"riscv,isa\" devicetree entry\n"); pr_warn("Unable to find \"riscv,isa\" devicetree entry\n");
continue; continue;
...@@ -137,7 +144,6 @@ void __init riscv_fill_hwcap(void) ...@@ -137,7 +144,6 @@ void __init riscv_fill_hwcap(void)
/* The riscv,isa DT property must start with rv64 or rv32 */ /* The riscv,isa DT property must start with rv64 or rv32 */
if (temp == isa) if (temp == isa)
continue; continue;
bitmap_zero(this_isa, RISCV_ISA_EXT_MAX);
for (; *isa; ++isa) { for (; *isa; ++isa) {
const char *ext = isa++; const char *ext = isa++;
const char *ext_end = isa; const char *ext_end = isa;
...@@ -215,7 +221,7 @@ void __init riscv_fill_hwcap(void) ...@@ -215,7 +221,7 @@ void __init riscv_fill_hwcap(void)
if ((ext_end - ext == sizeof(name) - 1) && \ if ((ext_end - ext == sizeof(name) - 1) && \
!memcmp(ext, name, sizeof(name) - 1) && \ !memcmp(ext, name, sizeof(name) - 1) && \
riscv_isa_extension_check(bit)) \ riscv_isa_extension_check(bit)) \
set_bit(bit, this_isa); \ set_bit(bit, isainfo->isa); \
} while (false) \ } while (false) \
if (unlikely(ext_err)) if (unlikely(ext_err))
...@@ -225,7 +231,7 @@ void __init riscv_fill_hwcap(void) ...@@ -225,7 +231,7 @@ void __init riscv_fill_hwcap(void)
if (riscv_isa_extension_check(nr)) { if (riscv_isa_extension_check(nr)) {
this_hwcap |= isa2hwcap[nr]; this_hwcap |= isa2hwcap[nr];
set_bit(nr, this_isa); set_bit(nr, isainfo->isa);
} }
} else { } else {
/* sorted alphabetically */ /* sorted alphabetically */
...@@ -257,9 +263,9 @@ void __init riscv_fill_hwcap(void) ...@@ -257,9 +263,9 @@ void __init riscv_fill_hwcap(void)
elf_hwcap = this_hwcap; elf_hwcap = this_hwcap;
if (bitmap_empty(riscv_isa, RISCV_ISA_EXT_MAX)) if (bitmap_empty(riscv_isa, RISCV_ISA_EXT_MAX))
bitmap_copy(riscv_isa, this_isa, RISCV_ISA_EXT_MAX); bitmap_copy(riscv_isa, isainfo->isa, RISCV_ISA_EXT_MAX);
else else
bitmap_and(riscv_isa, riscv_isa, this_isa, RISCV_ISA_EXT_MAX); bitmap_and(riscv_isa, riscv_isa, isainfo->isa, RISCV_ISA_EXT_MAX);
} }
/* We don't support systems with F but without D, so mask those out /* We don't support systems with F but without D, so mask those out
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment