Commit 8325cd1e authored by Kent Overstreet's avatar Kent Overstreet Committed by Kent Overstreet

bcachefs: Don't do upgrades in nochanges mode

nochanges mode is often used for getting data off of otherwise
nonrecoverable filesystems, which is often because of errors hit during
fsck.

Don't force version upgrade & fsck in nochanges mode, so that it's more
likely to mount.
Signed-off-by: default avatarKent Overstreet <kent.overstreet@gmail.com>
parent f124345e
...@@ -1081,15 +1081,17 @@ int bch2_fs_recovery(struct bch_fs *c) ...@@ -1081,15 +1081,17 @@ int bch2_fs_recovery(struct bch_fs *c)
set_bit(BCH_FS_REBUILD_REPLICAS, &c->flags); set_bit(BCH_FS_REBUILD_REPLICAS, &c->flags);
} }
if (c->sb.version < bcachefs_metadata_version_inode_backpointers) { if (!c->opts.nochanges) {
bch_info(c, "version prior to inode backpointers, upgrade and fsck required"); if (c->sb.version < bcachefs_metadata_version_inode_backpointers) {
c->opts.version_upgrade = true; bch_info(c, "version prior to inode backpointers, upgrade and fsck required");
c->opts.fsck = true; c->opts.version_upgrade = true;
c->opts.fix_errors = FSCK_OPT_YES; c->opts.fsck = true;
} else if (c->sb.version < bcachefs_metadata_version_subvol_dirent) { c->opts.fix_errors = FSCK_OPT_YES;
bch_info(c, "filesystem version is prior to subvol_dirent - upgrading"); } else if (c->sb.version < bcachefs_metadata_version_subvol_dirent) {
c->opts.version_upgrade = true; bch_info(c, "filesystem version is prior to subvol_dirent - upgrading");
c->opts.fsck = true; c->opts.version_upgrade = true;
c->opts.fsck = true;
}
} }
ret = bch2_blacklist_table_initialize(c); ret = bch2_blacklist_table_initialize(c);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment