Commit 835d89e9 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Shaohua Li

md-cluster: Fix a memleak in an error handling path

We know that 'bm_lockres' is NULL here, so 'lockres_free(bm_lockres)' is a
no-op. According to resource handling in case of error a few lines below,
it is likely that 'bitmap_free(bitmap)' was expected instead.

Fixes: b98938d1 ("md-cluster: introduce cluster_check_sync_size")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarGuoqing Jiang <gqjiang@suse.com>
Signed-off-by: default avatarShaohua Li <shli@fb.com>
parent 78b6350d
...@@ -1127,7 +1127,7 @@ int cluster_check_sync_size(struct mddev *mddev) ...@@ -1127,7 +1127,7 @@ int cluster_check_sync_size(struct mddev *mddev)
bm_lockres = lockres_init(mddev, str, NULL, 1); bm_lockres = lockres_init(mddev, str, NULL, 1);
if (!bm_lockres) { if (!bm_lockres) {
pr_err("md-cluster: Cannot initialize %s\n", str); pr_err("md-cluster: Cannot initialize %s\n", str);
lockres_free(bm_lockres); bitmap_free(bitmap);
return -1; return -1;
} }
bm_lockres->flags |= DLM_LKF_NOQUEUE; bm_lockres->flags |= DLM_LKF_NOQUEUE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment