Commit 840fe258 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Miguel Ojeda

auxdisplay: ht16k33: Fix frame buffer device blanking

As the ht16k33 frame buffer sub-driver does not register an
fb_ops.fb_blank() handler, blanking does not work:

    $ echo 1 > /sys/class/graphics/fb0/blank
    sh: write error: Invalid argument

Fix this by providing a handler that always returns zero, to make sure
blank events will be sent to the actual device handling the backlight.
Reported-by: default avatarRobin van der Gracht <robin@protonic.nl>
Suggested-by: default avatarRobin van der Gracht <robin@protonic.nl>
Fixes: 8992da44 ("auxdisplay: ht16k33: Driver for LED controller")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 80f9eb70
...@@ -219,6 +219,15 @@ static const struct backlight_ops ht16k33_bl_ops = { ...@@ -219,6 +219,15 @@ static const struct backlight_ops ht16k33_bl_ops = {
.check_fb = ht16k33_bl_check_fb, .check_fb = ht16k33_bl_check_fb,
}; };
/*
* Blank events will be passed to the actual device handling the backlight when
* we return zero here.
*/
static int ht16k33_blank(int blank, struct fb_info *info)
{
return 0;
}
static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma) static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma)
{ {
struct ht16k33_priv *priv = info->par; struct ht16k33_priv *priv = info->par;
...@@ -231,6 +240,7 @@ static const struct fb_ops ht16k33_fb_ops = { ...@@ -231,6 +240,7 @@ static const struct fb_ops ht16k33_fb_ops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.fb_read = fb_sys_read, .fb_read = fb_sys_read,
.fb_write = fb_sys_write, .fb_write = fb_sys_write,
.fb_blank = ht16k33_blank,
.fb_fillrect = sys_fillrect, .fb_fillrect = sys_fillrect,
.fb_copyarea = sys_copyarea, .fb_copyarea = sys_copyarea,
.fb_imageblit = sys_imageblit, .fb_imageblit = sys_imageblit,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment