Commit 848c1903 authored by Ioana Ciornei's avatar Ioana Ciornei Committed by Jakub Kicinski

dpaa2-mac: fix the remove path for non-MAC interfaces

Check if the interface is indeed connected to a MAC before trying to
close the DPMAC object representing it. Without this check we end up
working with a NULL pointer.

Fixes: d87e6063 ("dpaa2-mac: export MAC counters even when in TYPE_FIXED")
Signed-off-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/20210111171802.1826324-1-ciorneiioana@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 70b32d82
......@@ -4150,6 +4150,9 @@ static void dpaa2_eth_disconnect_mac(struct dpaa2_eth_priv *priv)
if (dpaa2_eth_is_type_phy(priv))
dpaa2_mac_disconnect(priv->mac);
if (!dpaa2_eth_has_mac(priv))
return;
dpaa2_mac_close(priv->mac);
kfree(priv->mac);
priv->mac = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment