Commit 84c3e5bf authored by Paul Gortmaker's avatar Paul Gortmaker

cris: don't use module_init for non-modular core eeprom.c code

The eeprom.c code is compiled based on the Kconfig setting
ETRAX_I2C_EEPROM, which is bool.  So the code is either built in
or absent.  It will never be modular, so using module_init as an
alias for __initcall is rather misleading.

Fix this up now, so that we can relocate module_init from
init.h into module.h in the future.  If we don't do this, we'd
have to add module.h to obviously non-modular code, and that
would be a worse thing.

Direct use of __initcall is discouraged, vs prioritized ones.
Use of device_initcall is consistent with what __initcall
maps onto, and hence does not change the init order, making the
impact of this change zero.   Should someone with real hardware
for boot testing want to change it later to arch_initcall or
something different, they can do that at a later date.

Cc: Mikael Starvik <starvik@axis.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: linux-cris-kernel@axis.com
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 4d38e5c4
...@@ -848,5 +848,4 @@ static void eeprom_disable_write_protect(void) ...@@ -848,5 +848,4 @@ static void eeprom_disable_write_protect(void)
/* Write protect disabled */ /* Write protect disabled */
} }
} }
device_initcall(eeprom_init);
module_init(eeprom_init);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment