Commit 856c634d authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman

firmware: Google VPD: Fix return value check in vpd_platform_init()

In case of error, the function platform_device_register_simple()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Fixes: 049a59db ("firmware: Google VPD sysfs driver")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f563dab4
...@@ -303,8 +303,8 @@ static int __init vpd_platform_init(void) ...@@ -303,8 +303,8 @@ static int __init vpd_platform_init(void)
struct platform_device *pdev; struct platform_device *pdev;
pdev = platform_device_register_simple("vpd", -1, NULL, 0); pdev = platform_device_register_simple("vpd", -1, NULL, 0);
if (!pdev) if (IS_ERR(pdev))
return -ENODEV; return PTR_ERR(pdev);
vpd_kobj = kobject_create_and_add("vpd", firmware_kobj); vpd_kobj = kobject_create_and_add("vpd", firmware_kobj);
if (!vpd_kobj) if (!vpd_kobj)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment