Commit 8620546c authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller

net: phy: micrel: add led-mode sanity check

Make sure never to update more than two bits when setting the led mode,
something which could for example change the reference-clock setting.
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57a38eff
...@@ -173,6 +173,11 @@ static int kszphy_setup_led(struct phy_device *phydev, ...@@ -173,6 +173,11 @@ static int kszphy_setup_led(struct phy_device *phydev,
if (of_property_read_u32(of_node, "micrel,led-mode", &val)) if (of_property_read_u32(of_node, "micrel,led-mode", &val))
return 0; return 0;
if (val > 3) {
dev_err(&phydev->dev, "invalid led mode: 0x%02x\n", val);
return -EINVAL;
}
temp = phy_read(phydev, reg); temp = phy_read(phydev, reg);
if (temp < 0) if (temp < 0)
return temp; return temp;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment