Commit 862c03ee authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

ipv6: fix possible mem leaks in ipv6_make_skb()

ip6_setup_cork() might return an error, while memory allocations have
been done and must be rolled back.

Fixes: 6422398c ("ipv6: introduce ipv6_make_skb")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Vlad Yasevich <vyasevich@gmail.com>
Reported-by: default avatarMike Maloney <maloney@google.com>
Acked-by: default avatarMike Maloney <maloney@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8f3d1946
...@@ -1735,9 +1735,10 @@ struct sk_buff *ip6_make_skb(struct sock *sk, ...@@ -1735,9 +1735,10 @@ struct sk_buff *ip6_make_skb(struct sock *sk,
cork.base.opt = NULL; cork.base.opt = NULL;
v6_cork.opt = NULL; v6_cork.opt = NULL;
err = ip6_setup_cork(sk, &cork, &v6_cork, ipc6, rt, fl6); err = ip6_setup_cork(sk, &cork, &v6_cork, ipc6, rt, fl6);
if (err) if (err) {
ip6_cork_release(&cork, &v6_cork);
return ERR_PTR(err); return ERR_PTR(err);
}
if (ipc6->dontfrag < 0) if (ipc6->dontfrag < 0)
ipc6->dontfrag = inet6_sk(sk)->dontfrag; ipc6->dontfrag = inet6_sk(sk)->dontfrag;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment