Commit 86594f6a authored by Luca Weiss's avatar Luca Weiss Committed by Mauro Carvalho Chehab

media: venus: hfi: avoid null dereference in deinit

If venus_probe fails at pm_runtime_put_sync the error handling first
calls hfi_destroy and afterwards hfi_core_deinit. As hfi_destroy sets
core->ops to NULL, hfi_core_deinit cannot call the core_deinit function
anymore.

Avoid this null pointer derefence by skipping the call when necessary.
Signed-off-by: default avatarLuca Weiss <luca.weiss@fairphone.com>
Signed-off-by: default avatarStanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 90307ebe
...@@ -104,6 +104,9 @@ int hfi_core_deinit(struct venus_core *core, bool blocking) ...@@ -104,6 +104,9 @@ int hfi_core_deinit(struct venus_core *core, bool blocking)
mutex_lock(&core->lock); mutex_lock(&core->lock);
} }
if (!core->ops)
goto unlock;
ret = core->ops->core_deinit(core); ret = core->ops->core_deinit(core);
if (!ret) if (!ret)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment